Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos on lines 1180 and 1436 #115

Merged
merged 1 commit into from Jan 11, 2022
Merged

Fix typos on lines 1180 and 1436 #115

merged 1 commit into from Jan 11, 2022

Conversation

thesunshade
Copy link
Contributor

This is just a small change to test out the process of making suggestions.

This is just a small change to test out the process of making suggestions.
@thesunshade
Copy link
Contributor Author

I'm still very new at this so I thought I would just make a small change to test out the whole process.

@sujato sujato merged commit 71bcf78 into suttacentral:master Jan 11, 2022
@sujato
Copy link
Contributor

sujato commented Jan 11, 2022

I'm not sure if we need to review every change. In an application, reviewing is good, because a single change can bork the whole app. Here that won't happen, unless there's a JSON error. JSON errors are bad! Make sure to throw the entire file in a JSON validator before committing:

https://duckduckgo.com/?t=ffab&q=validate+json&ia=answer

Otherwise, it may be best to make the changes on your own branch (or your own repo), commit every once in a while, and merge them when you're finished.

@thesunshade thesunshade deleted the patch-1 branch March 27, 2022 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants