-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nyanamoli/mn18.html #200
Conversation
That's British style if I'm not mistaken. I think it's optional, but there is a span class for the added text. Could just be put around everything in parens. Thanks for adding this sutta! |
Thanks Bhante! Add spans added ✅ |
Looking good, congrats. Just a few changes:
|
- use </p>\n<p> instead of <br> - use nya instead of tbw for para nums
Okay. Updated 😄 How does it look now? |
Great, let's go! |
<head> | ||
<meta charset='UTF-8'> | ||
<meta name='author' content='Nyanamoli Thera'> | ||
<title></title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it need a <title>
, Bhante @sujato?
This is the first PR in what may become a series adding some of Venerable Nyanamoli's MN translations from A Treasury of the Buddha's Words.
Please take extra care to review this one as it's my first legacy text and the future files will use this one as a template, especially the
footer
and name conventions.I kept the paragraph numbering the same as in the original and thus called them "tbw" numbers. Some of Ven Nyanamoli's "paragraphs" contained carriage returns within them. I've coded these up as
<br>
(with no additional whitespace). Is that correct?The book inexplicably uses single quotes for top level quotes and double quotes for nested quotes. I've reversed that decision and also removed hyphens that were added across line-breaks (and replaced
...
s with…
) but have otherwise left the text's (poor) punctuation alone, opting to only fix a single typo where an extra "the" had crept in before a pronoun.cc Bhante @sujato and @ccronje for review 😃