Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title to add class #1800

Open
sujato opened this issue Nov 30, 2020 · 1 comment
Open

Add title to add class #1800

sujato opened this issue Nov 30, 2020 · 1 comment
Labels
Type: explore Investigate options / determine (non-)action Type: improvement Make stuff better

Comments

@sujato
Copy link
Contributor

sujato commented Nov 30, 2020

texts have helper classes that indicate various aspects of the text.

One such class is add which you can see if you go here and search for 'womb':

https://staging.suttacentral.net/mn9/en/bodhi

The added text is a different color. But it should have a title attribute saying something like "Text added by translator or editor". This is probably no the only broken class!

The list of classes is here:

https://staging.suttacentral.net/zz1/zz/test

https://staging.suttacentral.net/zz3/zz/test

These are broken on the old site, too.

@thesunshade
Copy link
Collaborator

thesunshade commented Feb 6, 2024

I 100% agree that it is unclear to the readers why the text is a different colour.

I'm not sure what the reasoning behind abandoning the convention of putting added text in brackets. I admit it is kind of an academic convention, but frankly fussing about added words is an academic issue.

Titles are really flaky and are useless on touch devices/non mouse users. I'm not sure what the screen reader/accessibility issues with titles are, but they can't be good.

Also, even with a title/tool tip "Text added by translator or editor", the average reader won't understand why the text has been added. So although it seems like we are giving people more information with a tool tip, it's actually opening up more questions.

My feeling is that we should just go back to convention and use CSS ::before and ::after pseudo classes.

image

But…

On some legacy texts the author already puts in some kind of mark. Here is a Japanese legacy text. add class is purple to make it more clear:

image

And this is further complicated by the fact that in these Japanese legacy texts there are 〔〕 items for added words to make the translation work and ( ) items that are added explications.

@thesunshade thesunshade added Type: improvement Make stuff better Type: explore Investigate options / determine (non-)action labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: explore Investigate options / determine (non-)action Type: improvement Make stuff better
Projects
None yet
Development

No branches or pull requests

2 participants