Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes translated titles are not being used #2172

Closed
sujato opened this issue Jun 1, 2021 · 2 comments · Fixed by #2181
Closed

Sometimes translated titles are not being used #2172

sujato opened this issue Jun 1, 2021 · 2 comments · Fixed by #2181

Comments

@sujato
Copy link
Contributor

sujato commented Jun 1, 2021

Sometimes, even in English where we know all suttas are translated, we find a mix of translated titles and root language titles:

Screenshot from 2021-06-01 10-10-13

Always use translated title if there is one

@sujato sujato added this to To do in SC 2021: next step improvements via automation Jun 1, 2021
@ihongda ihongda moved this from To do to In progress in SC 2021: next step improvements Jun 1, 2021
@ihongda
Copy link
Contributor

ihongda commented Jun 1, 2021

The titles of some sutta are indeed untranslated, such as MN144, MN145:

bilara-data/translation/en/sujato/name/sutta/mn-name_translation-en-sujato.json

@sujato
Copy link
Contributor Author

sujato commented Jun 1, 2021

No, the sutta titles should pull from the name files first, then fallback to the sutta files if there is nothing in the name file.

We have always used the sutta files for adding names. The name files are an extra, which we use primarily for the upper navigation levels (vagga, etc.). There was never any intention to use only the name files.

See previous discussions:

#2039

#1660

In the following case, the sutta name is appearing on the site, even though it is not in the name file:

#2026
https://suttacentral.net/sn1.68

@sujato sujato closed this as completed Jun 4, 2021
SC 2021: next step improvements automation moved this from In progress to Done Jun 4, 2021
@ihongda ihongda linked a pull request Jun 4, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants