Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "notification" that there are more translations of a text in user's language #2989

Open
12 tasks
thesunshade opened this issue Feb 6, 2024 · 4 comments
Open
12 tasks
Labels
Type: improvement Make stuff better

Comments

@thesunshade
Copy link
Collaborator

User story

John is new to the site. He is sent a link to a sutta. Looking at that sutta there is no indication at all that there might be another translation of the exact same sutta because it's behind a couple of clicks. Poor John.

Elizabeth is very familiar with the site, however every time she wants to know if there is an additional translation of the text she is reading, she must click on the Parallels icon to see. She may even forget to check since it's not clear what might be waiting for her.

Feature description

If there is more than one translation of a text into the user's chosen site language, show some kind of indicator on the Parallels icon.

Acceptance criteria (the list of things that need to be done for the ticket to be considered finished):

Pre milestone planning check:

  • Small enough to completed in a milestone.
  • Dependencies marked
  • No external dependencies block the PBI from being completed.
  • Details are understood by dev team to decide if the PBI can be completed.

Done check:

  • Produced code for presumed functionalities
  • Project builds without errors
  • Peer Code Review performed/pull request approved x2
  • Project deployed on the stage environment identical to production platform
  • Feature is tested against acceptance criteria
  • Feature ok-ed by Product Owner (moving to Closed on the Board)
  • Refactoring completed
  • Any configuration or build changes documented (readme, etc...)
@khemarato
Copy link
Contributor

khemarato commented Feb 6, 2024

Nice! Would save me a click sometimes. I just hope this feature doesn't come with a performance cost. The site already takes a long time to load a sutta 😅

@thesunshade
Copy link
Collaborator Author

I think the api used to render the page already has the data on other translations, but I'm not sure. There does seem to be an additional api call when the parallels icon is clicked, so maybe not. But those API calls are lightening fast in my experience.

@khemarato
Copy link
Contributor

khemarato commented Feb 6, 2024

Those API calls haven't been lightning fast for me, which is why I know off the top of my head that clicking it makes one! 😅 But anyway that's probably off topic for this feature, which seems useful and reasonable (especially assuming the data is already there).

@thesunshade
Copy link
Collaborator Author

I guess ideally if an additional call is needed the notification could pop up after the page loads (which wouldn't be bad and might even be good).

I have also noticed that the new Voice icon gets added after the whole page loads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: improvement Make stuff better
Projects
None yet
Development

No branches or pull requests

2 participants