Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App-route does not handle dots in file or pathnames #3

Closed
ghost opened this issue Aug 6, 2017 · 5 comments
Closed

App-route does not handle dots in file or pathnames #3

ghost opened this issue Aug 6, 2017 · 5 comments
Labels
Type: bug Something isn’t working

Comments

@ghost
Copy link

ghost commented Aug 6, 2017

This is a big problem because many of our files have dots in them. I cannot load the AN or SN files the way things are now. Apparently it will work going through Firebase but that will be difficult for me with development. @blake-sc any ideas?

Filed bug report here:
https://github.com/Polymer/polyserve/issues/147

Stackoverflow question filed here:
https://stackoverflow.com/questions/45531951/polymer-2-0-iron-location-app-route-not-recognising-route

@ghost ghost added the Type: bug Something isn’t working label Aug 6, 2017
@blake-sc
Copy link
Contributor

blake-sc commented Aug 7, 2017

I am unable to reproduce this issue. URLs with dots in them are working fine for me. It seems to be thought that this is an issue with polymer serve, maybe the version of polymer serve makes a difference? Mine is 1.3.1. Or can the issue be narrowed down? Are the routes not working at all for you or only in particular contexts?

Btw I tested by renaming "dn" to "d.n" and "dn1" to "dn1.1" everywhere, and checking if the site still worked when using those modified uids, and it did work.

@ghost
Copy link
Author

ghost commented Aug 7, 2017

Did you try the MWE I posted on stackoverflow or did you try the next-sc full version? I've got 1.3.1 also.
Routes with any dots in are not working at all. Also tried dn1.1, etc. as you did.
And yes, as per the bug-report on Polyserve I posted above, it is indeed something to do with polyserve.

@blake-sc
Copy link
Contributor

blake-sc commented Aug 7, 2017

Well it's important to narrow the issue down. I'm having trouble working out if there is a problem with app-route at all, I don't think so, I pored over the source code and couldn't see any reference to '.', so the issue would seem to be strictly to do with the backend - polymer-cli in this case. I also tried modifying the tests to add urls with periods, these tests ran fine when executed in the browser, but crapped out when executed from polymer test, which strengthens the hypothesis that app-route is working fine.

@blake-sc
Copy link
Contributor

blake-sc commented Aug 7, 2017

Okay how about this as a resolution:

Use python server/app.py instead. I've updated it and it seems to work perfectly both normally and when refreshing/directly browsing to a page, I'm not seeing any problems with urls with periods in them.

@ghost
Copy link
Author

ghost commented Aug 7, 2017

With python it works fine. Thanks for that.
I had also come to the conclusion that it is not app-route itself because the problem occurs already before app-route or iron-location is activated.

@gradam gradam closed this as completed Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug Something isn’t working
Projects
None yet
Development

No branches or pull requests

2 participants