Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barista::CompilationError when javascript doesn't compile #5

Closed
pomartel opened this issue Oct 4, 2010 · 7 comments
Closed

Barista::CompilationError when javascript doesn't compile #5

pomartel opened this issue Oct 4, 2010 · 7 comments

Comments

@pomartel
Copy link

pomartel commented Oct 4, 2010

With latest version of Coffeescript (0.9.4) and Barista 0.5.1, I get this error when I have a syntax error in my coffeescript file :

"coffee -p --no-wrap '/Users/po/code/vendeur/app/coffeescripts/lunch.coffee'" exited with a non-zero status.

It used to tell me where the error was but now I have to manually run the coffee command to get a clue :

Error: In /Users/po/code/vendeur/app/coffeescripts/lunch.coffee, Parse error on line 13: Unexpected '='
at Object.parseError (/usr/local/lib/coffee-script/lib/parser.js:513:11)
...

Is this the normal behavior?

@Sutto
Copy link
Owner

Sutto commented Oct 9, 2010

I believe this was a change to how we report errors in Barista - my suggestion is to tie into the compilation_failed hook (via Barista.on_compilation_error - see the README) - this provides the error message as the second argument to your block.

@pomartel
Copy link
Author

I will have a look but displaying the Coffeescript error should probably be the default behavior of Barista. Without the error message, you have no idea where's the error in the code.

@stephencelis
Copy link

+1 pomartel

Default functionality should be helpful, not obscure.

@bawNg
Copy link

bawNg commented Nov 24, 2010

+1

@Sutto
Copy link
Owner

Sutto commented Nov 24, 2010

I'm doing a big overhaul of stuff for 1.0, And this has been added by default.

@Sutto
Copy link
Owner

Sutto commented Nov 28, 2010

Check out the latest gem - v0.7.0.pre2 - This automatically sets up an error warning by default.

@pomartel
Copy link
Author

pomartel commented Dec 1, 2010

Thanks for the change Sutto! It works for me.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants