Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Active Model Serializers #40

Closed
cableray opened this issue Dec 13, 2012 · 6 comments
Closed

Support for Active Model Serializers #40

cableray opened this issue Dec 13, 2012 · 6 comments

Comments

@cableray
Copy link

Given that rocket pants avoids views, serializers seem the best way to format data. rocket pants currently does not easily support Active Model Serializers, but it seems like it should look for them when available. I'll be providing a pull request for an example implementation shortly.

@Sutto
Copy link
Owner

Sutto commented Dec 17, 2012

Hey @cableray,

I'd definitely be interested in merging this in - it sounds like a super useful feature. Let me know how you go with the pull request, otherwise I'll be taking a look in the near future.

@harrisony
Copy link

Hi @cableray, did you get around to coding this? would save me having to attempt to do the same

@Sutto
Copy link
Owner

Sutto commented Jan 2, 2013

@harrisony I've started working on it, and will try and push a version of RocketPants with it in the next 24 hours.

@Sutto
Copy link
Owner

Sutto commented Jan 2, 2013

@harrisony @cableray Take a look at 1.6.0.rc1, it should support them now out of the box.

Just use expose and pass options as the second argument (e.g. for custom serializers).

@Sutto
Copy link
Owner

Sutto commented Jan 8, 2013

Closing since this is implemented.

@Sutto Sutto closed this as completed Jan 8, 2013
@cableray
Copy link
Author

Thanks Sutto, sorry I didn't get around to it. I'm looking for places to contribute to open source, but for some reason this is harder than it sounds. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants