Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle KeyboardInterrupt for inputscope-listener #19

Closed
wants to merge 1 commit into from

Conversation

ulcuber
Copy link
Contributor

@ulcuber ulcuber commented Jul 8, 2022

Resolves #16

@suurjaak
Copy link
Owner

suurjaak commented Jul 8, 2022

A good change, thank you, but I will have to decline this pull request, as the development happens in a private dev-branch. I will incorporate it there.

However, this would not resolve #16, as the problem with Ctrl-C is in main.py.

@suurjaak suurjaak closed this Jul 8, 2022
@ulcuber
Copy link
Contributor Author

ulcuber commented Jul 8, 2022

@suurjaak Yes, it does not resolve whole issue.
Where should open next pull requests? It would be useful to create CONTRIBUTING.md or DEVELOPERS.md

@suurjaak
Copy link
Owner

Over more than a decade of releasing open-source software, I think I've only ever received pull requests from like.. 2 people, so it has never really been a thing :)

But since pull requests cannot be disabled in GitHub anyway, users can always create one. In comparison to issues, they have the added benefit of code on the side, no matter whether and how the changes finally get incorporated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle SIGINT properly
2 participants