Integration script #40
Conversation
| @@ -74,6 +74,7 @@ | |||
| <h2>Heading</h2> | |||
| <p>Donec id elit non mi porta gravida at eget metus. Fusce dapibus, tellus ac cursus commodo, tortor mauris condimentum nibh, ut fermentum massa justo sit amet risus. Etiam porta sem malesuada magna mollis euismod. Donec sed odio dui. </p> | |||
| <p><a class="btn btn-default" href="#" role="button">View details »</a></p> | |||
| <!-- Fixed Image Gallery --> | |||
There was a problem hiding this comment.
Consider adding a toggle state to the button for adding individual images. Also adding an aria value to assist with identifying the toggle button behavior.
<p><a class="btn btn-default" href="#" role="button" data-toggle="button" aria-pressed="false" ">View details »</a></p>
There was a problem hiding this comment.
Agreed with @bvasilop's suggestion. Adding the aria-pressed will additionally meet accessibility criteria, making it easier for users with visual impairments to know what they're interacting with. Additionally, taking advantage of the aria-label will ensure a clear description of the button. Once the above changes are in place, resubmit PR for review and approval.
| @@ -74,6 +74,7 @@ | |||
| <h2>Heading</h2> | |||
| <p>Donec id elit non mi porta gravida at eget metus. Fusce dapibus, tellus ac cursus commodo, tortor mauris condimentum nibh, ut fermentum massa justo sit amet risus. Etiam porta sem malesuada magna mollis euismod. Donec sed odio dui. </p> | |||
| <p><a class="btn btn-default" href="#" role="button">View details »</a></p> | |||
| <!-- Fixed Image Gallery --> | |||
| <i class="fa fa-bookmark" aria-hidden="true"></i> <!-- Allows user to favorite poem --> | |||
There was a problem hiding this comment.
In addition to bookmarking the poem we should also add social icons so that the use may share the poem via social media: Facebook, Twitter, and Pinterest.
| @@ -97,6 +98,8 @@ | |||
| <script src="js/main.js"></script> | |||
|
|
|||
| <!-- Google Analytics: change UA-XXXXX-X to be your site's ID. --> | |||
|
|
|||
| <!-- Fixed The script, removed the original bug --> | |||
There was a problem hiding this comment.
Consider moving google analytics script from <body> to <head> with adding <script async src='https://www.google-analytics.com/analytics.js'></script> for optimizing load times.
Solved the original error.