Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to TS. Add some new props. Rewrite as a functional component #92

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

MikeSha
Copy link

@MikeSha MikeSha commented Dec 6, 2021

  1. Adds new props on updates existing
  • values string | string[] default values
  • placeholder string | string[] [] input placeholder. If string, the one placeholder will be added to all inputs
  • inputClassNames string | string[] [] input classnames. If string, the one class will be added to all inputs
  • disabled boolean false disables all inputs
  • required boolean false sets all inputs to be required
  • id string undefined adds id prefix to all inputs. If id is not defined, id of each input won't be defined either
  • loadingComponent JSX.Element Loader custom loader component
  1. Loader now can be a custom component

  2. Everything is rewritten on TypeScript as a functional component

  3. Tests

  4. Packages are updated

@suweya Apologies for not asking your opinion on TypeScript. The reason is simply a lack of time. My current project is written on TS and had to change some things in the original code. I simply not sure if I have any time to write it on JS. No worries if this PR will be declined.

@benmotyka
Copy link

great pr, unfortunately author of this lib is not active anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants