feat: avoid trigger increment-views call in link component prefetch #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to a Personal Account owned by @suyalcinkaya on Vercel. @suyalcinkaya first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
When I forked this project, I encountered an issue in production mode - the
increment_view_countRPC is triggered in the/writingroute due to Link prefetching. The middleware function looks fine and only runs on/writing/:path/.The problem is caused by Next.js's Link component prefetching all linked pages to improve UX.
To fix this, I had to differentiate between prefetched and normal user-initiated requests. I found that the solution in this discussion solves the prefetch issue nicely.
Apologies for the trouble, and thanks for this amazing work! Your blog looks concise and smooth.