Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create custom html template #2

Open
suyash-thakur opened this issue Mar 23, 2023 · 14 comments · May be fixed by #8
Open

Create custom html template #2

suyash-thakur opened this issue Mar 23, 2023 · 14 comments · May be fixed by #8
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@suyash-thakur
Copy link
Owner

Description:
Currently, the script only supports HTML generated by markdown-to-html. We would like to add support for a HTML template, so that the website looks much better.

Proposed Solution:
I propose to add a template.html file which holds a better looking website template and the html generated by markdown-to-html get wrapped by the template file before written into index.html

@suyash-thakur suyash-thakur added enhancement New feature or request good first issue Good for newcomers labels Mar 23, 2023
@Muhammad-Awab
Copy link

I would like to work on this project. Please assign to me.

@suyash-thakur
Copy link
Owner Author

Hey @Muhammad-Awab. You can fork the repo and make a MR. Also reach me out if you need any help.

@aparna03dubey
Copy link

If this is still unresolved, please assign it to me.

@suyash-thakur
Copy link
Owner Author

@aparna03dubey I have assigned you the issue. Let me know if you need any help.

@Parthiv31
Copy link

did you mean to enhance css of current index and put it in template.html for you to evaluate
I mean Im starting out so kindly do assist me with your requirement so that I could help

@suyash-thakur
Copy link
Owner Author

@Parthiv31 Current index.html file is generated by using markdown-to-html package because of which there is not much room for styling the webpage. To fix this issue we can create a template.html file which will contain all the styling for the webpage and the html generated by markdown-to-html can be dynamically populated inside template.html.

@suryanshgupta01
Copy link

suryanshgupta01 commented Jun 4, 2023

@suyash-thakur I'm working on it,
will fork it tonight only.
Edit: DONE

@geethdev
Copy link

geethdev commented Oct 1, 2023

Hey! I would like to contribute!

@simranroy01
Copy link

hey i would like to contribute, please assign it to me

@Manideep-Maddileti
Copy link

Hey..I want to work on this issue.Can you assign to me

@saksham-jain177
Copy link

@suyash-thakur I would like to work on this, please assign it to me

saksham-jain177 added a commit to saksham-jain177/js-good-first-issues-finder that referenced this issue Jan 17, 2024
Using Marked instead of Markdown
Please let me know if its wrong and guide me as per requirement
@saksham-jain177 saksham-jain177 linked a pull request Jan 17, 2024 that will close this issue
@Ishpreet01
Copy link

@suyash-thakur If this issue is still open, can I work on it?

@suyash-thakur
Copy link
Owner Author

@saksham-jain177 You have included node_modules in your PR 😬. Please exclude it and update your PR so that I can test it.

@suyash-thakur
Copy link
Owner Author

suyash-thakur commented Jan 30, 2024

@Ishpreet01 You can pick up the other issue if you are are interested. I will wait for @saksham-jain177 to update his PR for now.

saksham-jain177 added a commit to saksham-jain177/js-good-first-issues-finder that referenced this issue Jan 30, 2024
Using Marked instead of Markdown
Please let me know if its wrong and guide me as per requirement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
10 participants