This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
pronunciation parsing for heteronyms #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jsch8q Thank you for this! |
ZOUHEIRBN
added a commit
to ZOUHEIRBN/WiktionaryParser
that referenced
this pull request
Oct 9, 2023
pronunciation parsing for heteronyms
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For words that are heteronyms, the pronunciation parser does not work properly.
For example, when we fetch the word 'bass' by executing
the first definition should contain the pronunciation 'enPR: bās, IPA: /beɪs/' only, not the other pronunciations such as 'enPR: băs, IPA: /bæs/'.
I think this is a critical issue, since heteronyms such as the example 'bass' above have different meanings when pronounced differently. The revised code resolves this problem.