Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique Version String Feature #83

Closed
IChocked opened this issue Jun 2, 2020 · 1 comment · Fixed by #149
Closed

Unique Version String Feature #83

IChocked opened this issue Jun 2, 2020 · 1 comment · Fixed by #149

Comments

@IChocked
Copy link
Contributor

IChocked commented Jun 2, 2020

When debugging and testing fixes, it would be useful to have a function to call to be able to figure out what version of the library is running locally. As it is now, when testing the latest fix, I look at the files that were changed to figure out which version of the library it is, but it would be nice to be able to do something like dicom.Version()

@suyashkumar
Copy link
Owner

Yep I think that would be nice and I've considered something like that in the past. We'll have to think about how to incorporate such a string at build time.

One option: when running make release, write the current git hash out to a file which is then included in the binary build as a package variable. We could also consider the git tag as well, if present on the commit being built from.

suyashkumar pushed a commit that referenced this issue Dec 14, 2020
The version string will be injected at release step with the output of `git describe --tags --always`. This fixes #83.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants