Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to create frame, element, write, and query packages #21

Merged
merged 5 commits into from May 26, 2019

Conversation

suyashkumar
Copy link
Owner

@suyashkumar suyashkumar commented May 23, 2019

This change refactors the element and frame entities into their own packages. This does cause some annoying stutter (for example frame.Frame as opposed to dicom.Frame) which is something I am going to think about a bit before merging. There are many examples in the std lib of this, though (like context.Context for example.

This change also factors write and query logic into their own packages.

@suyashkumar suyashkumar changed the title [WIP] Refactor frame and element entities [WIP] Refactor to create frame, element, write, and query packages May 23, 2019
@suyashkumar
Copy link
Owner Author

Also, I do not really like element.DataSet ... perhaps DataSet should get its own package at some point, or the element package should get a different name.

@suyashkumar
Copy link
Owner Author

we should consider putting many of these packages into pkg/. However I do like having the main API exposed at the top level (can just import and use github.com/suyashkumar/dicom)...

@suyashkumar suyashkumar changed the title [WIP] Refactor to create frame, element, write, and query packages Refactor to create frame, element, write, and query packages May 24, 2019
@suyashkumar suyashkumar merged commit 6e2b4e9 into master May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant