Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WriteOption to override missing transfer syntax in dataset #332

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Add WriteOption to override missing transfer syntax in dataset #332

merged 3 commits into from
Jun 10, 2024

Conversation

suyashkumar
Copy link
Owner

@suyashkumar suyashkumar commented Jun 10, 2024 •
edited
Loading

This fixes #328. This change will also help set the stage for roundtrip tests for transfer syntax uid inference in the case of missing transfer syntax UIDs (part of #327).

This also makes an API breaking change to return an error from NewWriter, which imo makes sense.

For the future:

  • should we give this option as something to always override whatever transfer syntax is present (or if not present, use the override as well)?

@suyashkumar suyashkumar marked this pull request as ready for review June 10, 2024 02:06
@suyashkumar suyashkumar self-assigned this Jun 10, 2024
@suyashkumar suyashkumar added the enhancement New feature or request label Jun 10, 2024
@suyashkumar suyashkumar changed the title Add write option to override missing transfer syntax in dataset Add WriteOption to override missing transfer syntax in dataset Jun 10, 2024
@suyashkumar suyashkumar merged commit 0b4bb9f into main Jun 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@suyashkumar suyashkumar

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@suyashkumar