Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannot find package "golang.org/x/crypto/acme/autocert" #25

Closed
schildbach opened this issue Feb 4, 2020 · 2 comments · Fixed by #26
Closed

cannot find package "golang.org/x/crypto/acme/autocert" #25

schildbach opened this issue Feb 4, 2020 · 2 comments · Fixed by #26
Labels
bug Something isn't working

Comments

@schildbach
Copy link

schildbach commented Feb 4, 2020 •
edited

When building the Docker image from 83836bc, I get:

$ docker build -t my/ssl-proxy .
[...]
Step 6/6 : RUN make
 ---> Running in 0cc1b0b6fa3d
go mod download
warning: pattern "all" matched no module dependencies
go build -o ssl-proxy
main.go:16:2: cannot find package "golang.org/x/crypto/acme/autocert" in any of:
        /usr/local/go/src/golang.org/x/crypto/acme/autocert (from $GOROOT)
        /go/src/golang.org/x/crypto/acme/autocert (from $GOPATH)
make: *** [Makefile:6: build] Error 1
The command '/bin/sh -c make' returned a non-zero code: 2

This is on Ubuntu 18.04.4, using Docker version 18.09.7, build 2d0083d (from the Ubuntu repository).
@schildbach
Copy link
Author

Same problem on the v0.2.5 tag.

@suyashkumar suyashkumar mentioned this issue Feb 6, 2020
Merged
@suyashkumar
Copy link
Owner

Hi there @schildbach thanks so much for raising this issue! It appears this is because the Docker image used Go 1.12. After upgrading to Go 1.13, everything seems good to go. #26 should address this, and I'll look into GitHub actions that can test the Docker build as well if we will continue to maintain that. Let me know if you have any further trouble!

Thank you!

@suyashkumar suyashkumar added the bug Something isn't working label Feb 6, 2020
suyashkumar added a commit that referenced this issue Feb 6, 2020
@suyashkumar
Update Docker build to use Go 1.13.7 (#26)
89a1353 
This updates the Docker image to use Go 1.13.7, as Go 1.13+ is now required after #22. The GitHub actions CI was already using Go 1.13 so this was not caught there. If we will continue to maintain a Docker image to build ssl-proxy, some work should go into testing this docker build using GitHub actions as well!

Separately, we should investigate building against Go 1.14.

This closes #25.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Docker base layer to use Go 1.13 suyashkumar/ssl-proxy
2 participants
@schildbach @suyashkumar