Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading variable names #98

Open
aki-ks opened this issue May 14, 2018 · 0 comments
Open

Misleading variable names #98

aki-ks opened this issue May 14, 2018 · 0 comments

Comments

@aki-ks
Copy link

aki-ks commented May 14, 2018

The methods that create size oriented Pickle/UnpickleStates have wrong names.

boopickle/boopickle/shared/src/main/scala/boopickle/Pickler.scala

Line 529 in dfeadd4

implicit def pickleStateSpeed: PickleState = new PickleState(new EncoderSize, true, true)

boopickle/boopickle/shared/src/main/scala/boopickle/Pickler.scala

Line 596 in dfeadd4

implicit def unpickleStateSpeed: ByteBuffer => UnpickleState = bytes => new UnpickleState(new DecoderSize(bytes), true, true)

@aki-ks aki-ks changed the title Misleading variable name Misleading variable names May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aki-ks