Make Boopickle compiled with Java 9+ compatible with Java 8, close #124 #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Java 9 introduced several overloads to Buffer methods in ByteBuffer: * position(int newPosition) * limit(int newLimit) * flip() * clear() * mark() * reset() * rewind() Compiling such code with Java 9+ with cause it to crash at runtime with Java 8 with NoSuchMethodError. Modifications: Introduce a `Java8BufferCompat` helper to force linking to `java.nio.Buffer` methods. Result: Boopickle can be compiled with Java 9+ and executed with Java 8.
|
javac has a |
|
It has. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Java 9 introduced several overloads to Buffer methods in ByteBuffer:
Compiling such code with Java 9+ with cause it to crash at runtime with Java 8 with NoSuchMethodError.
Modifications:
Introduce a
Java8BufferCompathelper to force linking tojava.nio.Buffermethods.Result:
Boopickle can be compiled with Java 9+ and executed with Java 8.