Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specifiable cache key for SKPhoto and some tests about SKPhoto. #434

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add specifiable cache key for SKPhoto and some tests about SKPhoto. #434

wants to merge 2 commits into from

Conversation

fattiger00
Copy link

  1. It will fix Dynamically add url in skphotoBrowser is already presented  #425.
  2. Added some tests for SKPhoto to guarantee SKPhoto instances are functional.
  3. I'm willing to adjust the code if you had a better approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamically add url in skphotoBrowser is already presented
1 participant
@fattiger00