Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(migrate): to *-artifact v3+ -> v4+ #444

Merged

Conversation

NikitaCOEUR
Copy link
Contributor

Observation:

PR #409 and #408 are failling are failing. (Probably because they are interdependent)
The action uses upload-artifact@v3, download-artifact@v3, and checkout@v3 which are deprecated because they are based on node 16.

PR Summary:

Migration from upload-artifact@v3 -> v4
Migration from download-artifact@v3 -> v4
Migration from checkout@v3 -> v4
Migration of the renovate configuration from config:base -> config:recommends

Breaking Change:

As indicated here: https://github.com/actions/toolkit/tree/%40actions/artifact%402.0.1/packages/artifact Download-artifact and Upload-artifact in v4 do not work on GHES! So... ci-info-action with theses updates too.

store: migrate upload-artifact from v3 to v4
restore: migrate download-artifact from v3 to v4

BREAKING CHANGE: artifacts v4+ are currently not supported on GHES
(https://github.com/actions/toolkit/tree/main/packages/artifact)
@NikitaCOEUR NikitaCOEUR changed the title chore(migrate): to *-artifact v2+ -> v4+ chore(migrate): to *-artifact v3+ -> v4+ Feb 5, 2024
@suzuki-shunsuke
Copy link
Owner

Thank you for your contribution!

@suzuki-shunsuke suzuki-shunsuke added this to the v0.1.3 milestone Feb 5, 2024
@suzuki-shunsuke suzuki-shunsuke merged commit f3fead6 into suzuki-shunsuke:main Feb 5, 2024
4 checks passed
@suzuki-shunsuke
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants