Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add .github/pinact.yaml as a default config path #394

Merged
merged 3 commits into from
May 1, 2024
Merged

feat: add .github/pinact.yaml as a default config path #394

merged 3 commits into from
May 1, 2024

Conversation

kachick
Copy link
Contributor

@kachick kachick commented Apr 30, 2024

Resolves #393

kachick
kachick commented Apr 30, 2024
View reviewed changes
pkg/controller/run/main_internal_test.go
@@ -136,3 +136,49 @@ func TestController_patchLine(t *testing.T) {
})
}
}

func TestController_getConfigPath(t *testing.T) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I add test for readConfig instead of this extracted getConfigPath function?

@kachick kachick marked this pull request as draft April 30, 2024 20:29
@kachick
Copy link
Contributor Author

kachick commented Apr 30, 2024 •
edited
Loading

https://github.com/suzuki-shunsuke/pinact/actions/runs/8901267078/job/24444711917?pr=394

E2E diff check is failed, but go run ./cmd/pinact run in local made correct diff

Looks like facing API limit in GitHub action

time="2024-04-30T20:36:44Z" level=warning msg="get a reference" error="GET https://api.github.com/repos/suzuki-shunsuke/repo-404/commits/83b7061638ee4956cf7545a6f7efe594e5ad0247: 404 Not Found []" pinact_version= program=pinact workflow_file=testdata/foo.yaml
time="2024-04-30T20:36:44Z" level=warning msg="get a reference" error="GET https://api.github.com/repos/suzuki-shunsuke/actionlint-workflow/commits/v0.[5](https://github.com/suzuki-shunsuke/pinact/actions/runs/8901267078/job/24444711917?pr=394#step:9:6).0: 403 API rate limit of 60 still exceeded until 2024-04-30 21:03:19 +0000 UTC, not making remote request. [rate reset in 26m34s]" pinact_version= program=pinact workflow_file=testdata/foo.yaml

I sent another PR for this #395

@kachick kachick mentioned this pull request Apr 30, 2024
Merged
@kachick kachick marked this pull request as ready for review May 1, 2024 03:02
@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label May 1, 2024
@suzuki-shunsuke suzuki-shunsuke added this to the v0.1.3 milestone May 1, 2024
@suzuki-shunsuke
Copy link
Owner

Thank you!

@suzuki-shunsuke suzuki-shunsuke merged commit 7500059 into suzuki-shunsuke:main May 1, 2024
8 checks passed
@kachick
Copy link
Contributor Author

kachick commented May 1, 2024

Thank you for approved! 🙏

@kachick kachick deleted the feat-dotfiles-in-githubdir branch May 1, 2024 03:26
@suzuki-shunsuke
Copy link
Owner

v0.1.3 is out 🎉
https://github.com/suzuki-shunsuke/pinact/releases/tag/v0.1.3

kachick added a commit to kachick/anylang-template that referenced this pull request May 1, 2024
@kachick
Adjust pinact path
7a3b914 
suzuki-shunsuke/pinact#394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.1.3
Development

Successfully merging this pull request may close these issues.

Respect .github/pinact.yaml as the default config
2 participants
@kachick @suzuki-shunsuke