Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(setup): support setting google-github-actions/auth's access_token_scopes #1611

Merged
merged 3 commits into from
Apr 4, 2024
Merged

feat(setup): support setting google-github-actions/auth's access_token_scopes #1611

merged 3 commits into from
Apr 4, 2024

Conversation

suzuki-shunsuke
Copy link
Owner

@suzuki-shunsuke suzuki-shunsuke commented Mar 30, 2024 •
edited

This pull request adds the setting gcp_access_token_scopes to enable tfaction to set google-github-actions/auth's access_token_scopes.

The format is same with google-github-actions/auth's access_token_scopes.

tfaction-root.yaml

e.g.

targets:
- working_directory: gcp/
  target: gcp/
  terraform_plan_config:
    gcp_access_token_scopes: 'https://www.googleapis.com/auth/cloud-platform, https://www.googleapis.com/auth/userinfo.email, https://www.googleapis.com/auth/apps.groups.settings, https://www.googleapis.com/auth/admin.directory.group'

tfaction.yaml

terraform_plan_config:
  gcp_access_token_scopes: 'https://www.googleapis.com/auth/cloud-platform, https://www.googleapis.com/auth/userinfo.email, https://www.googleapis.com/auth/apps.groups.settings, https://www.googleapis.com/auth/admin.directory.group'

@suzuki-shunsuke suzuki-shunsuke changed the title feat(setup): support setting google-github-actions/auth's access_toke… feat(setup): support setting google-github-actions/auth's access_token_scopes Mar 30, 2024
@suzuki-shunsuke
Copy link
Owner Author

v1.4.0-1

https://github.com/suzuki-shunsuke/tfaction/releases/tag/v1.4.0-1

@suzuki-shunsuke suzuki-shunsuke marked this pull request as ready for review April 4, 2024 06:12
@suzuki-shunsuke suzuki-shunsuke merged commit 020f6d7 into main Apr 4, 2024
12 checks passed
@suzuki-shunsuke suzuki-shunsuke deleted the feat-google-auth-access_token_scopes branch April 4, 2024 06:13
@suzuki-shunsuke suzuki-shunsuke added this to the v1.4.0 milestone Apr 4, 2024
@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
main
Status: Done
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@suzuki-shunsuke