Add functionality to allow users provide a separate service account for gcs remote terraform backend #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 19, 2024
Closed
🚀 Pull Request Branch was created or updatedThe pull request branch pr/1643 was created or updated. You can try this pull request in your workflows by changing tfaction version to e.g. - uses: suzuki-shunsuke/tfaction/setup@pr/1643To update the pull request branch again, please run the workflow. |
|
Thank you for recreating the pull request! |
|
Thank you for the feedback. I'll try out |
|
i tried this on my setup, apply and plan workflows are working as expected with the new feature. |
|
Could you check this comment when you have time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on enhancing the Google Cloud Platform (GCP) integration in the
get-target-configandlibpackages. The changes introduce two new optional parameters,gcp_remote_backend_service_accountandgcp_remote_backend_workload_identity_provider, to therunfunction inget-target-config/src/run.tsand to theJobConfigandTargetGroupobjects inlib/src/index.ts. These parameters are then used insetup/action.yamlto authenticate with GCP if they are provided.GCP Integration Enhancements:
get-target-config/src/run.ts: Addedgcp_remote_backend_service_accountandgcp_remote_backend_workload_identity_providerto the list of parameters in therunfunction. These parameters are used to authenticate with GCP. [1] [2]lib/src/index.ts: Addedgcp_remote_backend_service_accountandgcp_remote_backend_workload_identity_provideras optional parameters to theJobConfigandTargetGroupobjects. These parameters are used to authenticate with GCP. [1] [2]setup/action.yaml: Added a new step to use thegoogle-github-actions/authaction with thegcp_remote_backend_service_accountandgcp_remote_backend_workload_identity_providerparameters if they are provided. This step authenticates with GCP and sets theGOOGLE_BACKEND_CREDENTIALSenvironment variable.this PR is a follow up PR for #1641