Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add HasDestry variable and remove the template for destroy #111

Merged
merged 6 commits into from Jul 17, 2021
Merged

feat: add HasDestry variable and remove the template for destroy #111

merged 6 commits into from Jul 17, 2021

Conversation

suzuki-shunsuke
Copy link
Owner

@suzuki-shunsuke suzuki-shunsuke commented Jul 16, 2021 •
edited

Close #110

BREAKING CHANGE

The configuration terraform.plan.when_destroy.template is removed.
When there are destroyed resources, the template terraform.plan.template is used.
The template variable HasDestroy is added, so using the variable we can unify the template.

terraform:
  plan:
    template: |
      {{if .HasDestroy}}{{template "deletion_warning" .}}{{end}}

Feature

Add the template variable HasDestroy

@suzuki-shunsuke suzuki-shunsuke added this to the v2.0.0 milestone Jul 16, 2021
@suzuki-shunsuke suzuki-shunsuke marked this pull request as ready for review July 17, 2021 00:26
@suzuki-shunsuke suzuki-shunsuke merged commit b7dca74 into main Jul 17, 2021
@suzuki-shunsuke suzuki-shunsuke deleted the feat/unify-template branch July 17, 2021 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change enhancement New feature or request
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

unify plan templates
1 participant
@suzuki-shunsuke