Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support masking secrets #1115

Merged
merged 4 commits into from Feb 1, 2024
Merged

feat: support masking secrets #1115

merged 4 commits into from Feb 1, 2024

Commits on Jan 26, 2024

  1. feat: support masking secrets

    @suzuki-shunsuke
    suzuki-shunsuke committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    d11124e View commit details
    Browse the repository at this point in the history

  2. fix: fix lint errors

    @suzuki-shunsuke
    suzuki-shunsuke committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    ec8e921 View commit details
    Browse the repository at this point in the history

  3. fix: fix error handling

    @suzuki-shunsuke
    suzuki-shunsuke committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    dcbce63 View commit details
    Browse the repository at this point in the history

  4. fix(mask): change the default separator from ; to , 

    `;` has a special meaning in shell script.

For example, the following command doesn't work as expected.

```sh
export TFCMT_MASKS=env:GITHUB_TOKEN;env:DATADOG_API_KEY
```

To prevent the bug, I change the separator.
    @suzuki-shunsuke
    suzuki-shunsuke committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    56dfca4 View commit details
    Browse the repository at this point in the history