Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change the behavior of destroy warning #32

Merged
merged 1 commit into from Jan 5, 2021

Conversation

suzuki-shunsuke
Copy link
Owner

@suzuki-shunsuke suzuki-shunsuke commented Jan 5, 2021

BREAKING CHANGE: change the behavior of destroy warning


AS IS

tfcmt posts a deletion warning comment as the other comment.

TO BE

tfcmt posts only one comment whose template is when_destroy.template.

    when_destroy:
      label: "destroy"
      label_color: "d93f0b"  # red
      template: |
        {{ .Title }}
        [CI link]( {{ .Link }} )
        This plan contains **resource deletion**. Please check the plan result very carefully!
        {{ .Message }}
        {{if .Result}}
        <pre><code>{{ .Result }}
        </pre></code>
        {{end}}
        <details><summary>Details (Click me)</summary>
        <pre><code>{{ .Body }}
        </pre></code></details>

And the default title of destroy warning is changed to ## :warning: Resource Deletion will happen :warning:.

@suzuki-shunsuke suzuki-shunsuke added breaking change documentation Improvements or additions to documentation enhancement New feature or request labels Jan 5, 2021
@suzuki-shunsuke suzuki-shunsuke added this to the v0.2.0 milestone Jan 5, 2021
BREAKING CHANGE: change the behavior of destroy warning
@suzuki-shunsuke suzuki-shunsuke force-pushed the feat/change-destroy-warning-behavior branch from 6b3431e to 1961ed6 Compare January 5, 2021 13:35
@suzuki-shunsuke suzuki-shunsuke merged commit 255f7d7 into master Jan 5, 2021
@suzuki-shunsuke suzuki-shunsuke deleted the feat/change-destroy-warning-behavior branch January 5, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant