Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up derive and make test assertions better #155

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

KodrAus
Copy link
Collaborator

@KodrAus KodrAus commented Sep 4, 2023

This PR works on our sval_test library to make it produce more useful messages when implementations of Value fail. A Value shouldn't fail itself, similarly to the expectation on Debug and Display, but if it does we should make some effort to communicate why.

I'm also splitting up sval_derive so that we can add extensions to it, like #[flatten], that might make use of other libraries like sval_buffer or sval_fmt.

@KodrAus KodrAus merged commit 8877403 into main Sep 4, 2023
38 checks passed
@KodrAus KodrAus deleted the feat/test-assertions branch September 4, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant