Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings and fallback to indexes as tags when labels are missing #192

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

KodrAus
Copy link
Collaborator

@KodrAus KodrAus commented Mar 26, 2024

This PR cleans up some new dead code lints and attempts to fall back to streaming a tag as its index if it has one but is missing a label.

@KodrAus
Copy link
Collaborator Author

KodrAus commented Mar 27, 2024

I've made the treatment of indexes consistent, so if there's an index but no label then we'll attempt to use it, either as the value, or as the key of the variant. If there's no label and no index then we'll treat the variant as null, so far tags and empty enums that;ll produce null, and for variants it'll be as if they're untagged.

@KodrAus KodrAus merged commit 7c02f48 into main Mar 27, 2024
50 checks passed
@KodrAus KodrAus deleted the fix/integer-tags branch March 27, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant