Update integration with CAD-to-DAGMC v0.6.2 for oo_version
#80
Conversation
connoramoreno
force-pushed
the
update-cad-to-dagmc
branch
from
551f2d3
to
a488f5f
Compare
|
I think that's probably OK, but maybe we don't close #79 yet... |
|
That makes sense to me! |
There was a problem hiding this comment.
One question/concern here.... not sure if it exists in the PR we already merged for the old version. It seems like the decision of cad_to_dagmc bind this data together more loosely is dangerous and risks material tags being out of sync with the objects. (@shimwell ?)
| for component in self.Components.values(): | ||
| model.add_cadquery_object(component) | ||
|
|
||
| material_tags = [ | ||
| component['mat_tag'] for component in self.radial_build.values() | ||
| ] |
There was a problem hiding this comment.
Do the relative orders of these things matter? One loops over self.Components and one over self.radial_build. Presumably those things are both built in the same order, but nothing guarantees it...?
It is a bit riskier yes, it does assume the user knows the number of solids in each added cadquery assembly or step file. The number of material tags is checked for the length of the total volumes in the solids but not at each stage of addition. I'm thinking I should go back to old api, please hold of on merging this. |
|
It's not just about the number, it's about the order! This API relies on the user to keep track of this data in a way that preserves this binding. |
|
I've changed cad-to-dagmc back to requesting material_tags when adding stp files of cadquery objects. I think this PR is no longer needed. Sorry for the mess |
Updates syntax in
export_cad_to_dagmcmethod ofInVesselBuildclass for theoo_versionbranch to reflect update to CAD-to-DAGMC dependency. The test script forInVesselBuildis also updated to incorporate testing of the in-vessel build DAGMC export.It should be noted that while the new syntax incorporated is correct, at the initial commit for this PR, there are issues when faceting a full period of the test/example geometry.
Closes #78.