Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use "''${dontNpmInstall-}" instead of "$dontNpmInstall" in node-env.nix #162

Closed
cdepillabout opened this issue Dec 3, 2019 · 1 comment
Closed

use "''${dontNpmInstall-}" instead of "$dontNpmInstall" in node-env.nix #162

cdepillabout opened this issue Dec 3, 2019 · 1 comment

Comments

@cdepillabout
Copy link

cdepillabout commented Dec 3, 2019 •
edited

There was a recent tree-wide update in nixpkgs that changed uses of dont* env vars:

NixOS/nixpkgs@2811b03

This also changed the node-env.nix file in nixpkgs:

NixOS/nixpkgs@2811b03#diff-30704c98a2c5c1c3f2129859e86e016c

However, when running generate.sh, the correct "''${dontNpmInstall-}" gets reverted back to the incorrect "$dontNpmInstall".

I think node2nix needs to be updated to use "''${dontNpmInstall-}".

This came up in NixOS/nixpkgs#74727.
@cdepillabout cdepillabout mentioned this issue Dec 3, 2019
Merged
10 tasks
@midchildan midchildan mentioned this issue Jan 20, 2020
Merged
9 tasks
@svanderburg
Copy link
Owner

This PR was integrated into master: 2a1be25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdepillabout @svanderburg