Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type .ico #1

Merged
merged 2 commits into from May 6, 2019
Merged

Add type .ico #1

merged 2 commits into from May 6, 2019

Conversation

@iwatakeshi
Copy link
Contributor

iwatakeshi commented May 6, 2019

This adds support for .ico files.

Copy link
Owner

svartalf left a comment

Everything else is great, I'll be ready to merge & publish this PR once the naming issue will be addressed.

src/lib.rs Outdated
@@ -37,6 +37,8 @@ pub enum Type {
Rgb,
/// FLIF (Free Lossless Image Format) files
Flif,
/// ICO files
ICO

This comment has been minimized.

Copy link
@svartalf

svartalf May 6, 2019

Owner

Enum variants should be in UpperCamelCase, like an Ico

@@ -16,6 +16,7 @@ const BMP: &'static [u8] = b"BM";
const BGP: &'static [u8] = b"BPG\xfb";
const RGB: &'static [u8] = b"\x01\xda";
const FLIF: &'static [u8] = b"FLIF";
const ICO: &'static [u8] = b"\x00\x00\x01\x00";

This comment has been minimized.

Copy link
@svartalf

svartalf May 6, 2019

Owner

Are .CUR images still exists, btw? Have not seen them for a decades.

This comment has been minimized.

Copy link
@iwatakeshi

iwatakeshi May 6, 2019

Author Contributor

I haven't seen them either. Also, it isn't listed as one of image's supported file types.

@svartalf svartalf merged commit c47e373 into svartalf:master May 6, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@svartalf
Copy link
Owner

svartalf commented May 6, 2019

Aaaand published. Thank you for a PR, @iwatakeshi!

@iwatakeshi
Copy link
Contributor Author

iwatakeshi commented May 6, 2019

@svartalf My pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.