New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type .ico #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else is great, I'll be ready to merge & publish this PR once the naming issue will be addressed.
src/lib.rs
Outdated
@@ -37,6 +37,8 @@ pub enum Type { | |||
Rgb, | |||
/// FLIF (Free Lossless Image Format) files | |||
Flif, | |||
/// ICO files | |||
ICO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enum variants should be in UpperCamelCase, like an Ico
@@ -16,6 +16,7 @@ const BMP: &'static [u8] = b"BM"; | |||
const BGP: &'static [u8] = b"BPG\xfb"; | |||
const RGB: &'static [u8] = b"\x01\xda"; | |||
const FLIF: &'static [u8] = b"FLIF"; | |||
const ICO: &'static [u8] = b"\x00\x00\x01\x00"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are .CUR
images still exists, btw? Have not seen them for a decades.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't seen them either. Also, it isn't listed as one of image's supported file types.
Aaaand published. Thank you for a PR, @iwatakeshi! |
@svartalf My pleasure! |
This adds support for
.ico
files.