Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Django 1.11.x #22

Closed
interDist opened this issue Jan 11, 2018 · 7 comments
Closed

Support for Django 1.11.x #22

interDist opened this issue Jan 11, 2018 · 7 comments

Comments

@interDist
Copy link

No description provided.

@ghost
Copy link

ghost commented Sep 20, 2018

Installing on new django 2.1.1 will downgrade it.
Can this widget still work if compiled?

@sveetch
Copy link
Owner

sveetch commented Sep 20, 2018

What do you mean with "compiled" ? Javascript asset minification ?

@ghost
Copy link

ghost commented Sep 20, 2018

compiled as in call python setyp.py with modified code...

Currently the project is aimed at Django 1.X which is OLD.. But I guess it may simply not work until the project is verified to work with Django 2.x.

@sveetch
Copy link
Owner

sveetch commented Sep 20, 2018

You could try support with the tests, just changing the tox config in a development environment: https://djangocodemirror.readthedocs.io/en/latest/development.html

But i'm pretty sure it won't work, since Django 1.11 there was some incompatible changes that breaks the widget i should have fixed before even thinking to Django 2.x

@interDist
Copy link
Author

are these fixes planned for some point in time? or is the project considered abandoned?

@sveetch
Copy link
Owner

sveetch commented Sep 23, 2018

It's on the way, i got some tests to fix with Django 1.11, Django 2.0 should not take more time. This should be released to a new major version at the end of the week.

sveetch added a commit that referenced this issue Sep 27, 2018
* Rewrite package to use 'setup.cfg';
* Add support for Django 1.11, Django 2.0 and Django 2.1, close #22;
* Drop support for Django 1.8 and 1.9;
* Django 1.11 support is the last one for Python2;
* Change old demo project to more cleaner sandbox;
* Change widget to use new Django widget API;
sveetch added a commit that referenced this issue Sep 27, 2018
* Rewrite package to use 'setup.cfg';
* Add support for Django 1.11, Django 2.0 and Django 2.1, close #22;
* Drop support for Django 1.8 and 1.9;
* Django 1.11 support is the last one for Python2;
* Change old demo project to more cleaner sandbox;
* Change widget to use new Django widget API;
sveetch added a commit that referenced this issue Sep 28, 2018
Add support for Django>=1.11. Close #22
@ghost
Copy link

ghost commented Sep 29, 2018

Who hoo?!

Thanks for the amazing update :-)

Going to try it now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants