-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: post-conditions #388
Conversation
🦋 Changeset detectedLatest commit: 6df0f79 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@AdrianGonz97 Would you mind reviewing this, even if this is not directly testable? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise everything looks good! although, I do have a few questions:
So if a postcondition fails for a user, what are the actionable steps that a user should take when an error is thrown? Should it tell the user how to fix it (if it can be fixed)? Should it provide a link to our issue tracker and ask them to raise an issue?
Closes #337 (preconditions already implemented by #368)
Usage:
Will be helpful for all adders that we cannot check with integration testing, like #338, #339 , etc.
This is currently not implemented for any adder, as all adders are currently testable by integration testing. Future adders will use this feature.
Console output looks like this:
![image](https://private-user-images.githubusercontent.com/30698007/339411393-1f7b45b3-63eb-4e71-8c8c-1f8dbafd25d4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1NjgyNTUsIm5iZiI6MTcyMDU2Nzk1NSwicGF0aCI6Ii8zMDY5ODAwNy8zMzk0MTEzOTMtMWY3YjQ1YjMtNjNlYi00ZTcxLThjOGMtMWY4ZGJhZmQyNWQ0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA5VDIzMzIzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUyYWNkZjM0MmFiNWQ5MDc4MzI2YzBiOTFjNGM2MGE0YmQ3MjMyNzczZWQ4NTY5MTE1YWNmODRjNjY1MmU5MTcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.VoI7wTIoyrynVnY12WNfChyB7viBT3xycIDAyX-mmfE)