issue #163 #168
issue #163 #168
Conversation
|
✔️ Deploy Preview for sveltesociety-preview ready! 🔨 Explore the source changes: 56b188b 🔍 Inspect the deploy log: https://app.netlify.com/sites/sveltesociety-preview/deploys/618d39f0593d59000768afea 😎 Browse the preview: https://deploy-preview-168--sveltesociety-preview.netlify.app |
|
We probably could detect the string length and whether it needed to be split into multiple lines, but this is a good start either way :-) |
|
Thanks! My thought here was that it's probably best not to be reimplementing Prettier functionality because it wouldn't be tied to the lint/prettier config. If implemented as a github action it could be setup to run only when the json files change. It would also be resilient against any other changes that a person would make when editing the file. |
|
Can a Github action automatically update someone's fork of this repo though? |
|
Hmm... Good question. Possibly using a |
Changes the json snippet to use tabs instead of spaces, and updates the styling on the pre tag so it looks the same as before (\t was indented 8 spaces without the style change).
This doesn't handle formatting the tags array because the correct formating is driven by prettier and depends on the length of the array. I think the best way to handle this is to add a formatting job to the github actions that runs before the linter. I can add that action with this pull request as well if desired.