Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #163 #168

Closed
wants to merge 5 commits into from
Closed

issue #163 #168

wants to merge 5 commits into from

Conversation

srmullen
Copy link
Contributor

@srmullen srmullen commented Nov 9, 2021

Changes the json snippet to use tabs instead of spaces, and updates the styling on the pre tag so it looks the same as before (\t was indented 8 spaces without the style change).

This doesn't handle formatting the tags array because the correct formating is driven by prettier and depends on the length of the array. I think the best way to handle this is to add a formatting job to the github actions that runs before the linter. I can add that action with this pull request as well if desired.

@netlify
Copy link

netlify bot commented Nov 9, 2021

✔️ Deploy Preview for sveltesociety-preview ready!

🔨 Explore the source changes: 56b188b

🔍 Inspect the deploy log: https://app.netlify.com/sites/sveltesociety-preview/deploys/618d39f0593d59000768afea

😎 Browse the preview: https://deploy-preview-168--sveltesociety-preview.netlify.app

@benmccann benmccann linked an issue Nov 10, 2021 that may be closed by this pull request
@benmccann
Copy link
Collaborator

We probably could detect the string length and whether it needed to be split into multiple lines, but this is a good start either way :-)

@srmullen
Copy link
Contributor Author

Thanks! My thought here was that it's probably best not to be reimplementing Prettier functionality because it wouldn't be tied to the lint/prettier config.

If implemented as a github action it could be setup to run only when the json files change. It would also be resilient against any other changes that a person would make when editing the file.

@benmccann
Copy link
Collaborator

Can a Github action automatically update someone's fork of this repo though?

@srmullen
Copy link
Contributor Author

Hmm... Good question. Possibly using a pull_request_target event (https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows#pull_request_target), but I don't know for sure.

@srmullen srmullen closed this Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

component builder produces poorly formatted output
2 participants