Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid implementation problem #2

Merged
merged 1 commit into from
Jun 6, 2020
Merged

avoid implementation problem #2

merged 1 commit into from
Jun 6, 2020

Conversation

dertin
Copy link
Contributor

@dertin dertin commented Jun 6, 2020

alert("foo");

if ( !window.rendering ) {  // ignore rendering
   window.location.href = 'https://example.com/';
}

window.location.href = 'https://example.com/'; // Error: Not implemented: navigation (except hash changes)

alert("foo");

if ( !window.rendering ) {
   window.location.href = 'https://example.com/';
}
@jakobrosenberg jakobrosenberg merged commit 9941be9 into roxiness:master Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants