turn off @typescript-eslint/indent and rely exclusively on indent #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apparently @typescript-eslint/indent has 'myriad problems', so its more appropriate to rely solely on 'indent' rule related: typescript-eslint/typescript-eslint#1824
4 tasks
benmccann
approved these changes
Jun 17, 2020
|
This has been fixed in |
|
Closing in favor of #2. |
zappen999
added a commit
to mybonus-com/eslint-config
that referenced
this pull request
Sep 29, 2020
Indentation rules in TypeScript together with eslint is extremely
complex. Mixing with settings makes this even worse.
Disabling the eslint indentation rule and letting prettier decide what
to do instead.
My specific problem was that eslint and prettier was not consistent
about the indentation of long lines of type-aliases as return-types.
Example of how prettier wants it:
function example (): Example<
ThisIsALongTypeT,
ThisIsAnotherOneT,
EtcT
> {
// ...
}
Example how eslint wants it (with the indentation rule):
function example (): Example<
ThisIsALongTypeT,
ThisIsAnotherOneT,
EtcT
> {
// ...
}
Related links:
- typescript-eslint/typescript-eslint#1824
- sveltejs/eslint-config#1
After removing this line, prettier does a nice job of indenting it
correctly, and eslint doesn't complain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as requested in: sveltejs/svelte#5031 (comment)
apparently @typescript-eslint/indent has 'myriad problems', so its probably more appropriate to rely solely on 'indent' rule.
more context: sveltejs/svelte#5031 (comment)
related: typescript-eslint/typescript-eslint#1824