Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix isKitPageComponent on windows #318

Merged
merged 2 commits into from
Dec 12, 2022
Merged

Conversation

DetachHead
Copy link
Contributor

it always returned false on windows because file paths are separated by \ instead of /

@changeset-bot
Copy link

changeset-bot bot commented Dec 12, 2022

🦋 Changeset detected

Latest commit: 589a696

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 12, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@baseballyama
Copy link
Member

@DetachHead

Thank you for your contribution!
It looks good to me!

Could you please add a changeset?

@baseballyama
Copy link
Member

@ota-meshi

Should we add mac/windows CI?

@DetachHead
Copy link
Contributor Author

@baseballyama i can't get the changeset command to run on my PC.

>npx changeset
🦋  What kind of change is this for eslint-plugin-svelte? (current version is 2.14.0) · patch
🦋  Please enter a summary for this change (this will be in the changelogs).
🦋    (submit empty line to open external editor)
🦋  Summary · fix `isKitPageComponent` on windows
🦋
🦋  === Summary of changesets ===
🦋  patch:  eslint-plugin-svelte
🦋
🦋  Is this your desired changeset? (Y/n) · true
🦋  error TypeError: Cannot read properties of undefined (reading 'tokenTypeIdx')
🦋  error     at C:\projects\eslint-plugin-svelte\node_modules\@toml-tools\parser\node_modules\chevrotain\lib\src\scan\tokens.js:91:78
🦋  error     at Object.forEach (C:\projects\eslint-plugin-svelte\node_modules\@toml-tools\parser\node_modules\chevrotain\lib\src\utils\utils.js:85:30)
🦋  error     at C:\projects\eslint-plugin-svelte\node_modules\@toml-tools\parser\node_modules\chevrotain\lib\src\scan\tokens.js:90:17
🦋  error     at Object.forEach (C:\projects\eslint-plugin-svelte\node_modules\@toml-tools\parser\node_modules\chevrotain\lib\src\utils\utils.js:77:30)
🦋  error     at assignCategoriesTokensProp (C:\projects\eslint-plugin-svelte\node_modules\@toml-tools\parser\node_modules\chevrotain\lib\src\scan\tokens.js:87:13)
🦋  error     at Object.augmentTokenTypes (C:\projects\eslint-plugin-svelte\node_modules\@toml-tools\parser\node_modules\chevrotain\lib\src\scan\tokens.js:32:5)
🦋  error     at RecognizerEngine.initRecognizerEngine (C:\projects\eslint-plugin-svelte\node_modules\@toml-tools\parser\node_modules\chevrotain\lib\src\parse\parser\traits\recognizer_engine.js:86:18)
🦋  error     at new Parser (C:\projects\eslint-plugin-svelte\node_modules\@toml-tools\parser\node_modules\chevrotain\lib\src\parse\parser\parser.js:69:14)
🦋  error     at new TomlParser (C:\projects\eslint-plugin-svelte\node_modules\@toml-tools\parser\lib\parser.js:6:5)
🦋  error     at Object.<anonymous> (C:\projects\eslint-plugin-svelte\node_modules\@toml-tools\parser\lib\api.js:4:16)
🦋  error     at Module._compile (node:internal/modules/cjs/loader:1149:14)
🦋  error     at Module._extensions..js (node:internal/modules/cjs/loader:1203:10)
🦋  error     at Module._load (node:internal/modules/cjs/loader:868:12)
🦋  error     at Module.require (node:internal/modules/cjs/loader:1051:19)
🦋  error     at require (node:internal/modules/cjs/helpers:103:18)
🦋  error     at C:\projects\eslint-plugin-svelte\node_modules\prettier\index.js:37796:10
🦋  error     at Array.map (<anonymous>)
🦋  error     at Object.load (C:\projects\eslint-plugin-svelte\node_modules\prettier\index.js:37794:128)
🦋  error     at Object.load [as loadPlugins] (C:\projects\eslint-plugin-svelte\node_modules\prettier\index.js:15932:23)
🦋  error     at C:\projects\eslint-plugin-svelte\node_modules\prettier\index.js:37834:24
🦋  error     at Object.format (C:\projects\eslint-plugin-svelte\node_modules\prettier\index.js:37850:12)
🦋  error     at Object.writeChangeset [as default] (C:\projects\eslint-plugin-svelte\node_modules\@changesets\write\dist\write.cjs.dev.js:105:26)
🦋  error     at async add (C:\projects\eslint-plugin-svelte\node_modules\@changesets\cli\dist\cli.cjs.dev.js:543:25)
🦋  error     at async run$2 (C:\projects\eslint-plugin-svelte\node_modules\@changesets\cli\dist\cli.cjs.dev.js:1327:5)

would you mind doing it for me? thanks

@DetachHead
Copy link
Contributor Author

nvm i just made the file manually

@ota-meshi
Copy link
Member

@DetachHead Thank you for the PR! The changes you made look good to me.

@baseballyama

@ota-meshi Should we add mac/windows CI?

As you said, it would be better if there were tests for each platform.

@baseballyama baseballyama merged commit 53d4fda into sveltejs:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants