Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added the experimental-require-slot-types rule #368

Merged
merged 15 commits into from
Feb 10, 2023
Merged

feat: Added the experimental-require-slot-types rule #368

merged 15 commits into from
Feb 10, 2023

Conversation

marekdedic
Copy link
Contributor

Closes #347

Depends on #365 being merged first - it introduces the experimental rules section

@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2023

🦋 Changeset detected

Latest commit: df62ef4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-svelte Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 8, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@marekdedic marekdedic marked this pull request as ready for review February 9, 2023 10:35
@marekdedic
Copy link
Contributor Author

Hey, @ota-meshi, there's something broken with prettier and the line

https://github.com/ota-meshi/eslint-plugin-svelte/blob/f38495d1ae07a261dfc3ae7f9803bb0abf021399/tools/render-rules.ts#L14

It keeps switching back and forth whether it wants parentheses or not, event when there are no changes to the file in question

@ota-meshi
Copy link
Member

I think Prettier changed the format way in a minor version. I think you and we need to remove yarn.lock and node_modules and re-install.

@marekdedic
Copy link
Contributor Author

Ok, ok, I think this PR will pass now and I will just pull master & remove node_modules then. Thanks

@marekdedic
Copy link
Contributor Author

... or not :D

docs/rules/experimental-require-slot-types.md Outdated Show resolved Hide resolved
docs/rules/experimental-require-slot-types.md Outdated Show resolved Hide resolved
docs/rules/experimental-require-slot-types.md Outdated Show resolved Hide resolved
docs/rules/experimental-require-slot-types.md Outdated Show resolved Hide resolved
docs/rules/experimental-require-slot-types.md Outdated Show resolved Hide resolved
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit fcb5e31 into sveltejs:main Feb 10, 2023
@marekdedic marekdedic deleted the require-slot-types branch February 10, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New rule: require-slot-types
2 participants