Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all config #407

Merged
merged 4 commits into from
Mar 18, 2023
Merged

all config #407

merged 4 commits into from
Mar 18, 2023

Conversation

DetachHead
Copy link
Contributor

fixes #369

@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2023

🦋 Changeset detected

Latest commit: 9513d2e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-svelte Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DetachHead DetachHead force-pushed the all-config branch 2 times, most recently from 8ce0a79 to 4c107cf Compare March 17, 2023 08:02
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 17, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document the caveats as mentioned in the issue. I think we also need to export from index.ts. Also we need to resolve the CI (linting) error.

@DetachHead
Copy link
Contributor Author

added the documentation and the export. as for the CI error, i have no idea what's going on. as far as i can tell it's unrelated because locally when i run the tests after reverting my changes the errors still occur

@ota-meshi
Copy link
Member

Thank you for the PR. As you said, the remaining CI errors appear unrelated to the changes in the PR. I will look into the cause later.

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit c394a80 into sveltejs:main Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export an all config
2 participants