Prod mode page errors (#3151)

* add error getters in prod mode, at least for now * changeset
sveltejs · Dec 30, 2021 · 42a55eb · 42a55eb
1 parent c1f5eb2
commit 42a55eb
Show file tree

Hide file tree

Showing 4 changed files with 51 additions and 52 deletions.
diff --git a/.changeset/ten-hairs-perform.md b/.changeset/ten-hairs-perform.md
@@ -0,0 +1,5 @@
+---
+'@sveltejs/kit': patch
+---
+
+Add path/query error getters in prod mode
diff --git a/packages/kit/src/runtime/client/renderer.js b/packages/kit/src/runtime/client/renderer.js
@@ -445,24 +445,22 @@ export class Renderer {
 		if (!this.current.url || url.href !== this.current.url.href) {
 			result.props.page = { url, params };
 
-			if (import.meta.env.DEV) {
-				// TODO remove this for 1.0
-				/**
-				 * @param {string} property
-				 * @param {string} replacement
-				 */
-				const print_error = (property, replacement) => {
-					Object.defineProperty(result.props.page, property, {
-						get: () => {
-							throw new Error(`$page.${property} has been replaced by $page.url.${replacement}`);
-						}
-					});
-				};
+			// TODO remove this for 1.0
+			/**
+			 * @param {string} property
+			 * @param {string} replacement
+			 */
+			const print_error = (property, replacement) => {
+				Object.defineProperty(result.props.page, property, {
+					get: () => {
+						throw new Error(`$page.${property} has been replaced by $page.url.${replacement}`);
+					}
+				});
+			};
 
-				print_error('origin', 'origin');
-				print_error('path', 'pathname');
-				print_error('query', 'searchParams');
-			}
+			print_error('origin', 'origin');
+			print_error('path', 'pathname');
+			print_error('query', 'searchParams');
 		}
 
 		const leaf = filtered[filtered.length - 1];

diff --git a/packages/kit/src/runtime/server/index.js b/packages/kit/src/runtime/server/index.js
@@ -43,24 +43,22 @@ export async function respond(incoming, options, state = {}) {
 		locals: {}
 	};
 
-	if (options.dev) {
-		// TODO remove this for 1.0
-		/**
-		 * @param {string} property
-		 * @param {string} replacement
-		 */
-		const print_error = (property, replacement) => {
-			Object.defineProperty(request, property, {
-				get: () => {
-					throw new Error(`request.${property} has been replaced by request.url.${replacement}`);
-				}
-			});
-		};
+	// TODO remove this for 1.0
+	/**
+	 * @param {string} property
+	 * @param {string} replacement
+	 */
+	const print_error = (property, replacement) => {
+		Object.defineProperty(request, property, {
+			get: () => {
+				throw new Error(`request.${property} has been replaced by request.url.${replacement}`);
+			}
+		});
+	};
 
-		print_error('origin', 'origin');
-		print_error('path', 'pathname');
-		print_error('query', 'searchParams');
-	}
+	print_error('origin', 'origin');
+	print_error('path', 'pathname');
+	print_error('query', 'searchParams');
 
 	try {
 		return await options.hooks.handle({

diff --git a/packages/kit/src/runtime/server/page/render.js b/packages/kit/src/runtime/server/page/render.js
@@ -72,24 +72,22 @@ export async function render_response({
 			components: branch.map(({ node }) => node.module.default)
 		};
 
-		if (options.dev) {
-			// TODO remove this for 1.0
-			/**
-			 * @param {string} property
-			 * @param {string} replacement
-			 */
-			const print_error = (property, replacement) => {
-				Object.defineProperty(props.page, property, {
-					get: () => {
-						throw new Error(`$page.${property} has been replaced by $page.url.${replacement}`);
-					}
-				});
-			};
-
-			print_error('origin', 'origin');
-			print_error('path', 'pathname');
-			print_error('query', 'searchParams');
-		}
+		// TODO remove this for 1.0
+		/**
+		 * @param {string} property
+		 * @param {string} replacement
+		 */
+		const print_error = (property, replacement) => {
+			Object.defineProperty(props.page, property, {
+				get: () => {
+					throw new Error(`$page.${property} has been replaced by $page.url.${replacement}`);
+				}
+			});
+		};
+
+		print_error('origin', 'origin');
+		print_error('path', 'pathname');
+		print_error('query', 'searchParams');
 
 		// props_n (instead of props[n]) makes it easy to avoid
 		// unnecessary updates for layout components