chore: run CI tests on Node 20 (#9706)

Co-authored-by: gtmnayan <gtmnayan@gmail.com>
sveltejs · May 5, 2023 · a1fe0bf · a1fe0bf
1 parent 39cbb58
commit a1fe0bf
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/.github/workflows/audit.yml b/.github/workflows/audit.yml
@@ -19,7 +19,7 @@ jobs:
       - uses: pnpm/action-setup@v2.2.4
       - uses: actions/setup-node@v3
         with:
-          node-version: '16.x'
+          node-version: '20.x'
           cache: pnpm
       - run: pnpm install --frozen-lockfile
       # check prod dependencies as these would affect users

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -44,6 +44,9 @@ jobs:
           - node-version: 18
             os: ubuntu-latest
             e2e-browser: 'chromium'
+          - node-version: 20
+            os: ubuntu-latest
+            e2e-browser: 'chromium'
     env:
       KIT_E2E_BROWSER: ${{matrix.e2e-browser}}
     steps:

diff --git a/packages/kit/src/utils/url.js b/packages/kit/src/utils/url.js
@@ -93,9 +93,15 @@ export function decode_uri(uri) {
 /**
  * URL properties that could change during the lifetime of the page,
  * which excludes things like `origin`
- * @type {Array<keyof URL>}
  */
-const tracked_url_properties = ['href', 'pathname', 'search', 'searchParams', 'toString', 'toJSON'];
+const tracked_url_properties = /** @type {const} */ ([
+	'href',
+	'pathname',
+	'search',
+	'searchParams',
+	'toString',
+	'toJSON'
+]);
 
 /**
  * @param {URL} url
@@ -105,12 +111,10 @@ export function make_trackable(url, callback) {
 	const tracked = new URL(url);
 
 	for (const property of tracked_url_properties) {
-		let value = tracked[property];
-
 		Object.defineProperty(tracked, property, {
 			get() {
 				callback();
-				return value;
+				return url[property];
 			},
 
 			enumerable: true,