Skip to content

Commit

Permalink
Re-enable all tests
Browse files Browse the repository at this point in the history
  • Loading branch information
benmccann committed Aug 2, 2021
1 parent 595e3dc commit e8b391b
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 8 deletions.
6 changes: 0 additions & 6 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
# IMPORTANT

There is current a bug which results in our tests not being run: https://github.com/sveltejs/kit/issues/2069

As a result, we are unlikely to merge any PRs until that issue is fixed. Help would be appreciated in fixing that issue.

### Before submitting the PR, please make sure you do the following
- [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
- [ ] This message body should clearly illustrate what problems it solves.
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ You can run the tests for only a single package by first moving to that director

You must rebuild each time before running the tests if you've made code changes.

To run a single integration test, provide the `FILTER` env var with the test name. E.g. `FILTER="includes paths" pnpm test:integration`. You're also supposed to be a open up the file and change `test` to `test.only`, but this doesn't work as well. Help would be appreciated in fixing that.
To run a single integration test, provide the `FILTER` env var with the test name. E.g. `FILTER="includes paths" pnpm test:integration`. You can also open up the file and change `test` to `test.only`.

You can run the test server with `cd packages/kit/test/apps/basics; pnpm run dev` to hit it with your browser.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export default function (test) {
assert.equal(await res.text(), '<foo />');
});

test.only('gets binary response with XML Content-Type', null, async ({ fetch }) => {
test('gets binary response with XML Content-Type', null, async ({ fetch }) => {
const res = await fetch('/endpoint-output/xml-bytes');

assert.equal(res.headers.get('content-type'), 'application/xml');
Expand Down

0 comments on commit e8b391b

Please sign in to comment.