Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested error components #519

Closed
Rich-Harris opened this issue Mar 14, 2021 · 2 comments
Closed

Nested error components #519

Rich-Harris opened this issue Mar 14, 2021 · 2 comments

Comments

@Rich-Harris
Copy link
Member

We have nested $layout components, but only a top-level $error. It might be useful to support nested error components as well:

image

In this example, if routes/settings/notifications/$error.svelte errored in load, we'd then try rendering routes/settings/$error.svelte, etc.
@Rich-Harris Rich-Harris mentioned this issue Apr 3, 2021
Merged
5 tasks
@arxpoetica
Copy link
Member

Crazy thought -- should error pages belong in layout pages?

This was referenced Apr 3, 2021
Closed
Merged
Merged
Rich-Harris pushed a commit that referenced this issue Apr 5, 2021
lay more groundwork for #519/#626 (#882)
a3a10b2 
* load all components up-front

* typechecking

* invoke router on startup if no SSR

* getting closer

* tests passing

* remove trial script

* fix unsubscription

* lint

* rename some stuff
Rich-Harris pushed a commit that referenced this issue Apr 5, 2021
Final (I think) stepping stone PR towards #519/#626 (#893)
ccb8825 
* create separate _load_error method

* make error component available to renderer

* include root layout in route manifests

* note to self

* allow unspecified adapter

* gah whoops

* smarter chunking

* fix chunking

* update tests
@Rich-Harris Rich-Harris mentioned this issue Apr 6, 2021
Merged
5 tasks
@stephane-vanraes stephane-vanraes mentioned this issue Apr 8, 2021
Closed
@Conduitry
Copy link
Member

This was implemented back in #901.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arxpoetica @Rich-Harris @Conduitry