-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static manifest.json file is overridden with generated file #5803
Comments
|
It looks like it's a configurable option for Vite, but something SK manages and uses. It sets it to be generated here, using it here I don't know if it's used at runtime or just as part of the build process, but maybe a less-likely-to-conflict fixed name could be used instead of the default or a temporary name created, that doesn't exists in the static files? |
SvelteKit needs it. We don't control the name. Vite hardcodes that. I think that the real issue isn't the name, but rather that it outputs it to the directory where the results go. It should probably go to a separate configurable directory. |
The name can be set (it defaults to https://vitejs.dev/config/build-options.html#build-manifest It looks like Vite has options to have the |
This is a huge problem for us! Just found! Is there any workaround for now? |
You could simply name your manifest That's the official file extension for webmanifests anyway. |
It works amazingly! Thanks! |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
I just noticed that this bug is affecting kit.svelte.dev |
Describe the bug
A manifest file added to the static folder i.e.
/static/manifest.json
is overwritten with a generated SvelteKit file at runtime (happens with adapter-node & adapter-auto).Reproduction
Add
/static/manifest.json
file:Build / run app, request
/manifest.json
, response is like:Logs
No response
System Info
Severity
serious, but I can work around it
Additional Information
manifest.json
is specifically mentioned as an example of using a static file:The text was updated successfully, but these errors were encountered: