Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site: sync to current svelte.dev #10187

Merged
merged 56 commits into from
Aug 9, 2023
Merged

Conversation

PuruVJ
Copy link
Contributor

@PuruVJ PuruVJ commented Jun 18, 2023

Syncs this site to svelte.dev, in terms of styling and rendering logic. WIP

closes #10452

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Jun 18, 2023

⚠️ No Changeset found

Latest commit: dbf986f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann
Copy link
Member

Looks like linting is failing on the CI

@PuruVJ
Copy link
Contributor Author

PuruVJ commented Jun 21, 2023

It's not done yet, lots to fix here. Will address when site-kit renderer is robust enough

@@ -0,0 +1,5 @@
import { redirect } from '@sveltejs/kit';

export const GET = ({}) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a +page.js so that it works with the client side router without a full page reload.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


/** @param {URL} url */
function get_nav_title(url) {
const list = new Map([[/^docs/, 'Docs']]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can just be a list of tuples instead of a map.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

svelte.dev uses a map like this, and that has multiple elements. Keeping a map here for consistency sake is not a bad idea IMHO

Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
<span class="large"><Icon name="discord" /></span>
</a>

<a href="https://github.com/sveltejs/svelte" title="GitHub Repo">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PuruVJ wrong link

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed: 9c82e14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: hamburger menu clickable area is too small
4 participants