Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use global URLSearchParams instead of import from url #1020

Merged
merged 2 commits into from
Apr 14, 2021

Conversation

GrygrFlzr
Copy link
Member

URLSearchParams is globally available since Node 10, and importing from url introduces issues with Cloudflare Workers; webpack seems to bring its own version that does not have url.URLSearchParams.

@Conduitry
Copy link
Member

Conduitry commented Apr 14, 2021

I assume #1019 is this issue.

edit: Oh, yep, just saw your comment on Discord.

Can you add a changeset?

@GrygrFlzr
Copy link
Member Author

Partially - util.types.isAnyArrayBuffer and util.types.isBoxedPrimitive is used by node-fetch and also not available in the CFW environment, so this doesn't yet close that issue.

@Conduitry
Copy link
Member

Hm. Do you have any idea how we're going to resolve that? I don't see how we could without forking node-fetch or getting them to change their use of those Node-only built-in libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants