Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump svelte peer-dependency #10225

Merged
merged 1 commit into from Jun 23, 2023
Merged

chore: bump svelte peer-dependency #10225

merged 1 commit into from Jun 23, 2023

Conversation

hyunbinseo
Copy link
Contributor

Cannot update a Svelte library to Svelte v4 due to peer-dependency issue.

npx svelte-migrate svelte-4
npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @sveltejs/package@2.0.2
npm ERR! Found: svelte@4.0.0
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer svelte@"^3.44.0" from @sveltejs/package@2.0.2
npm ERR! node_modules/@sveltejs/package
npm ERR!   dev @sveltejs/package@"^2.0.0" from the root project

Hopefully this fixes the problem?

{
  "name": "@sveltejs/package",
  "peerDependencies": {
-   "svelte": "^3.44.0"
+   "svelte": "^3.44.0 || ^4.0.0"
  }
}

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Jun 23, 2023

🦋 Changeset detected

Latest commit: 3dd31c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/package Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dummdidumm dummdidumm merged commit 61091fa into sveltejs:master Jun 23, 2023
12 of 13 checks passed
@github-actions github-actions bot mentioned this pull request Jun 23, 2023
@hyunbinseo hyunbinseo deleted the patch-1 branch June 23, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants